Skip to content

[Form] Fix constants #16862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

[Form] Fix constants #16862

merged 1 commit into from
Jun 10, 2022

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jun 9, 2022 •
edited
Loading

See down in the file

* ``\NumberFormatter::ROUND_HALFUP`` Round towards the
  "nearest neighbor". If both neighbors are equidistant, round up. It rounds
  ``2.5`` to ``3``, ``1.6`` and ``1.5`` to ``2`` and ``1.4`` to ``1``.

@OskarStark OskarStark added the Form label Jun 9, 2022
@OskarStark OskarStark requested a review from xabbuh as a code owner June 9, 2022 21:48
@carsonbot carsonbot added this to the 5.4 milestone Jun 9, 2022
@carsonbot carsonbot changed the title Fix constants [Form] Fix constants Jun 9, 2022
@javiereguiluz
Copy link
Member

Thank you Oskar.

@javiereguiluz javiereguiluz merged commit 797e5d0 into 5.4 Jun 10, 2022
@javiereguiluz javiereguiluz deleted the fix/number-type branch June 10, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@igst igst igst approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @javiereguiluz @xabbuh @igst @carsonbot